[Translation] skip tests if required class does not exist #38004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Aug 31, 2020
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
|
Builds on AppVeyor only fail for |
2889892 to
a545deb
Compare
|
ah, looks like the failure was actually caused by #37371 which was merged into |
a545deb to
801b3a5
Compare
derrabus
reviewed
Aug 31, 2020
| @@ -59,6 +59,10 @@ protected function deleteTmpDir() | |||
| */ | |||
| public function testThatACacheIsUsed($debug) | |||
| { | |||
| if (!class_exists(\MessageFormatter::class)) { | |||
| $this->markTestSkipped(sprintf('Skipping test as the "%s" class does not exist.', \MessageFormatter::class)); | |||
There was a problem hiding this comment.
The class does not exist when ext-intl is missing. I think the message should reflect that.
There was a problem hiding this comment.
Good idea, I have updated the message to provide more information.
There was a problem hiding this comment.
Suggesting the PHP extension or the polyfill package is inline with the exception that is thrown by the IntlFormatter.
801b3a5 to
427fffa
Compare
|
everything's back to green \o/ |
fabpot
approved these changes
Aug 31, 2020
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.