Skip to content

Add tests for translated error messages of json authentication #38044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Add tests for translated error messages of json authentication #38044

merged 1 commit into from
Sep 3, 2020

Conversation

malteschlueter
Copy link
Contributor

@malteschlueter malteschlueter commented Sep 3, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets #33168
License MIT
Doc PR -

In PR #38037 i added the translator to the json authenticator but there are some tests missing. I added some now.

@fabpot
Copy link
Member

fabpot commented Sep 3, 2020

Tests for the low requirements must be fixed.

@wouterj
Copy link
Member

wouterj commented Sep 3, 2020

Oh sorry, missed that test failure. For your information, this means that you should add a dev dependency on symfony/translation in the Http and Core security composer.json files.

@malteschlueter
Copy link
Contributor Author

malteschlueter commented Sep 3, 2020

Oh sorry, missed that test failure. For your information, this means that you should add a dev dependency on symfony/translation in the Http and Core security composer.json files.

Thanks for the tip @wouterj.

I understand why to add it to the Http Security but why should i added it also to Core Security? I didn't changed anything in this "area".

@wouterj
Copy link
Member

wouterj commented Sep 3, 2020

I understand why to add it to the Http Security but why should i added it also to Core Security? I didn't changed anything in this "area".

My mistake (in my mind, all authentication listeners lived in Core, but most of them actually live in Http).

👍 the remaining test failure is not caused by this PR

@fabpot
Copy link
Member

fabpot commented Sep 3, 2020

Thank you @malteschlueter.

@fabpot fabpot merged commit 4c96577 into symfony:master Sep 3, 2020
@malteschlueter malteschlueter deleted the issue/33168-add-tests-for-translated-exceptions branch September 7, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants