Skip to content

[Debug] Parse "x not found" errors correctly on php 8 #38049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Sep 3, 2020

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Part of #36872
License MIT
Doc PR N/A

PHP 8 uses double quotes instead of single ones in error messages. This PR teaches ClassNotFoundFatalErrorHandler to parse the new format.

Depends on composer/composer#9183

@derrabus derrabus force-pushed the bugfix/php8-not-found-error branch from b00a488 to 275496a Compare September 3, 2020 22:12
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Sep 4, 2020
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be applied to ErrorHandler when merging up.

@fabpot
Copy link
Member

fabpot commented Sep 4, 2020

Thank you @derrabus.

@fabpot fabpot merged commit 9460894 into symfony:3.4 Sep 4, 2020
@derrabus derrabus deleted the bugfix/php8-not-found-error branch September 4, 2020 11:30
fabpot added a commit that referenced this pull request Sep 8, 2020
… 8 (derrabus)

This PR was merged into the 4.4 branch.

Discussion
----------

[ErrorHandler] Parse "x not found" errors correctly on php 8

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | N/A

This PR is #38049 applied to the 4.4 branch.

Commits
-------

d9c9aea [ErrorHandler] Parse "x not found" errors correctly on php 8.
@xabbuh xabbuh mentioned this pull request Sep 8, 2020
This was referenced Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants