Skip to content

Increase HttpBrowser::getHeaders() visibility to protected #38052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Increase HttpBrowser::getHeaders() visibility to protected #38052

merged 1 commit into from
Sep 4, 2020

Conversation

iansltx
Copy link
Contributor

@iansltx iansltx commented Sep 4, 2020

Resolves #38051

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #38051
License MIT
Doc PR symfony/symfony-docs#...

Increases visibility to allow for oddball header overrides; see #38051 for more detail.

If this looks good, let me know if this is worth adding docs/changelog entries and I'll do so.

Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@fabpot
Copy link
Member

fabpot commented Sep 4, 2020

Thank you @iansltx.

@fabpot fabpot merged commit c2522fa into symfony:master Sep 4, 2020
@iansltx iansltx deleted the httpbrowser-protected-get-headers branch September 4, 2020 06:27
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Sep 7, 2020
This PR was squashed before being merged into the master branch.

Discussion
----------

Add information about HttpBrowser header handling

Includes information on overriding getHeaders() for special header requirements, thanks to fix in symfony/symfony#38052.

Resolves #14170

Commits
-------

a4d71a2 Add information about HttpBrowser header handling
@fabpot fabpot mentioned this pull request Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change HttpBrowser::getHeaders() method visibility to protected from private
3 participants