[PhpUnitBridge] Skip internal classes in CoverageListenerTrait #38094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
|
@derrabus if you have a second to have a look |
|
Can you provide an example of a test that would fail without your changes? |
|
Sure, this is how it looks. This |
|
A relevant commit: sebastianbergmann/phpunit@e06850c A test for |
nicolas-grekas
approved these changes
Sep 8, 2020
|
Thank you @sanmai. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 15, 2020
This PR was merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] Fix error with ReflectionClass | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT Introduced in #38094. Wish I know how I missed that. Commits ------- ed1bffe [PhpUnitBridge] Fix error with ReflectionClass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit 9+ is picky about test covering, say, a
\RuntimeException. Fails with the likes:Judging by the commit sebastianbergmann/phpunit@e06850c this change is required for PHPUnit 9.1 and up. Here's it being tested.