[HttpClient] Fix Array to string conversion notice when parsing JSON error body with non-scalar detail property #38122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error body with non-scalar detail property
nicolas-grekas
approved these changes
Sep 9, 2020
|
Thank you @emarref. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An earlier commit added the ability to detect common API formats and extract a useful error message from the error response payload. To achieve this, if a
titleanddetailproperty are found in the error response, the response is considered to be in a known format (RFC 7807) and these values are concatenated to form a helpful error message.However, when either
titleordetailproperty are present, but the document is not intended to follow the RFC semantics, if the properties are not scalar (e.g. if the detail property is an array of field validation violations) then the concatenation of the strings causes a notice to be raised.This pull request checks that the
titleanddetailproperties are scalar before attempting to concatenate them. If they are not, no enhanced error message is provided.