[Cache] Limit cache version character range #38126
Conversation
| $id = key($keys); | ||
| throw new InvalidArgumentException(sprintf('Could not match value id "%s" to keys "%s".', $id, implode('", "', $keys))); |
There was a problem hiding this comment.
This is what lead to the mix up of values. The assumption here is: if the id of the value cannot be found in the original keys, let’s just assume it to be the first one. Instead of returning a wrong value, we should create a miss here.
There was a problem hiding this comment.
I realize I wasn’t precise in my language: this is not the root cause of the issue but the subsequent error that lead to values being mixed up. The root cause was that they version ID contained a slash, that slash was replaced with a null byte in decodeKey and therefore the keys no longer matched and the piece of code above was triggered.
There was a problem hiding this comment.
FYI, we missed patching this other file, now fixed:
25941ff
| $id = key($keys); | ||
| throw new InvalidArgumentException(sprintf('Could not match value id "%s" to keys "%s".', $id, implode('", "', $keys))); |
|
@nicolas-grekas the original randomness is restored, the patch should be good now |
|
Thank you @lstrojny |
Follow up for #38108
With current HEAD in 4.4, this will fail eventually:
simple-phpunit --repeat 1000 --stop-on-failure --filter "testGetMultiple$" src/Symfony/Component/Cache/Tests/Simple/MemcachedCacheTextModeTest.phpAfter this PR it will no longer fail
@nicolas-grekas