Skip to content

[Messenger] Run postgres setup trigger in transaction #38136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2020
Merged

[Messenger] Run postgres setup trigger in transaction #38136

merged 1 commit into from
Sep 10, 2020

Conversation

akondas
Copy link
Contributor

@akondas akondas commented Sep 10, 2020

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #37179
License MIT
Doc PR n/a

This PR fix messenger:setup-transports command when using with doctrine/doctrine-bundle version >= 2.1

@akondas akondas requested a review from sroze as a code owner September 10, 2020 08:04
@nicolas-grekas nicolas-grekas added this to the 5.1 milestone Sep 10, 2020
Nyholm
Nyholm approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big THANK YOU for this.

I've tested in a sf 5.1 app with doctrine bundle 2.1 and doctrine common 2.7. It works as expected.

@nicolas-grekas
Copy link
Member

Thank you @akondas.

@nicolas-grekas nicolas-grekas merged commit f1fd3c0 into symfony:5.1 Sep 10, 2020
@akondas akondas deleted the setup-fix branch September 11, 2020 07:17
@chalasr chalasr mentioned this pull request Sep 21, 2020
Closed
@fabpot fabpot mentioned this pull request Sep 27, 2020
Merged
@fabpot fabpot mentioned this pull request Feb 1, 2021
Merged
fabpot added a commit that referenced this pull request Feb 1, 2021
@fabpot
bug #40055 [Messenger] Fix Doctrine setup when using a migration (fab…
8f325f5 
…pot)

This PR was merged into the 5.2 branch.

Discussion
----------

[Messenger] Fix Doctrine setup when using a migration

| Q             | A
| ------------- | ---
| Branch?       | 5.2 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #39928 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | n/a

#38136 fixed running `messenger:setup-transports` (issue reported in #37179), but it breaks usage with `make:migration` (reported in #39928) as code is already executed in a transaction.

This PR fixes both use cases.

Commits
-------

42eeb44 [Messenger] Fix Doctrine setup when using a migration
@akondas akondas mentioned this pull request Feb 4, 2021
Closed
@baiiko baiiko mentioned this pull request Feb 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@Nyholm Nyholm Nyholm approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@akondas @nicolas-grekas @Nyholm @carsonbot