Skip to content

[Mailer] Fixed Mailgun API bridge JsonException when API response is not applicaton/json #38147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2020
Merged

[Mailer] Fixed Mailgun API bridge JsonException when API response is not applicaton/json #38147

merged 1 commit into from
Sep 10, 2020

Conversation

asprega
Copy link
Contributor

@asprega asprega commented Sep 10, 2020

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #38146
License MIT
Doc PR -

Handles gracefully cases in which the Mailgun API does not return JSON responses.

@asprega
Copy link
Contributor Author

asprega commented Sep 10, 2020 •
edited
Loading

I think that the test faliure is unrelated, maybe a flaky test? (MemcacheAdapterTest)

@fabpot
Copy link
Member

fabpot commented Sep 10, 2020

Thank you @asprega.

@fabpot fabpot merged commit b84f3ce into symfony:5.1 Sep 10, 2020
@fabpot fabpot mentioned this pull request Sep 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug Mailer Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asprega @fabpot @nicolas-grekas @carsonbot