[SecurityBundle] Comma separated ips for security.access_control #38149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf95e64 to
eb570f3
Compare
src/Symfony/Bundle/SecurityBundle/DependencyInjection/MainConfiguration.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/MainConfigurationTest.php
Outdated
Show resolved
Hide resolved
| $ips = null !== $ips ? (array) $ips : []; | ||
|
|
||
| $this->ips = array_reduce($ips, static function (array $ips, string $ip) { | ||
| return array_merge($ips, preg_split('/\s*,\s*/', $ip)); |
There was a problem hiding this comment.
for next reviewers, this is the core of the PR
nicolas-grekas
approved these changes
Sep 11, 2020
nicolas-grekas
approved these changes
Sep 11, 2020
fabpot
approved these changes
Sep 12, 2020
a3e3e40 to
0412e91
Compare
|
Thank you @a-menshchikov. |
Merged
nicolas-grekas
added a commit
that referenced
this pull request
May 7, 2021
… comma-separated string (edefimov) This PR was merged into the 5.2 branch. Discussion ---------- [Security] Allow ips parameter in access_control to accept comma-separated string | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #40881, #40864, #40865 | License | MIT PR #38149 introduced a new feature to accept a comma-separated string in ip adresses setting in `access_control` configuration section of security bundle. However the feature works in inconsistent manner: comma-separated string can be successfully passed via environment variable, but can not be passed as plain string. This PR changes this inconsistent behavior by allowing validation pass if comma-separated list of ip addresses is given in plain string. More detailed explanation about the inconsistent behavior can be found [here](#40881 (comment)) Commits ------- 8947482 [SecurityBundle] Allow ips parameter in access_control accept comma-separated string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no way to use env vars to configure
security.access_controlips with multiple values. Ability to use comma separated ips make it able.