Skip to content

[Cache] fix ProxyAdapter not persisting items with infinite expiration #38156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2020
Merged

[Cache] fix ProxyAdapter not persisting items with infinite expiration #38156

merged 1 commit into from
Sep 11, 2020

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #38066
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Sep 11, 2020
@nicolas-grekas
Copy link
Member Author

Thank you @dmaicher.

@nicolas-grekas nicolas-grekas merged commit ac18887 into symfony:4.4 Sep 11, 2020
@dmaicher
Copy link
Contributor

Thanks a lot @nicolas-grekas 😊 Can confirm this fixes the issues I had on my app

@nicolas-grekas nicolas-grekas deleted the reproducer_38066 branch September 14, 2020 09:19
This was referenced Sep 27, 2020
Merged
Merged
@sbelyshkin sbelyshkin mentioned this pull request Dec 12, 2021
Merged
nicolas-grekas added a commit that referenced this pull request Dec 16, 2021
@nicolas-grekas
bug #44577 [Cache] Fix proxy no expiration to the Redis (Sergey Belys…
aaa18df 
…hkin)

This PR was merged into the 4.4 branch.

Discussion
----------

[Cache] Fix proxy no expiration to the Redis

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | - <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        |

After #38156 RedisAdapter is not able to persist items with no expiration which come through ProxyAdapter because Redis does not persist keys with very large TTL such as \PHP_INT_MAX (64 bits).

Commits
-------

0812726 [Cache] Fix saving items with no expiration through ProxyAdapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Cache Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @dmaicher @carsonbot