[Config] Adding the "info" to a missing option error messages #38176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
commented
Sep 13, 2020
src/Symfony/Bridge/Doctrine/DependencyInjection/Security/UserProvider/EntityFactory.php
Show resolved
Hide resolved
| $ex = new InvalidConfigurationException(sprintf('The child node "%s" at path "%s" must be configured.', $name, $this->getPath())); | ||
| $message = sprintf('The child config "%s" under "%s" must be configured.', $name, $this->getPath()); | ||
| if ($child->getInfo()) { | ||
| $message .= sprintf("\n\n Description: %s", $child->getInfo()); |
There was a problem hiding this comment.
I'm not sure if the \n\n is a problem. It sure does help readability.
There was a problem hiding this comment.
Having \n\n looks ok to me. Maybe we can remove the space before Description: , I would even remove the Description: prefix.
There was a problem hiding this comment.
Expected value for the "%s" option: %s instead of Description?
There was a problem hiding this comment.
What do you think? Having a one liner as suggested by Nicolas seems good to me.
|
Fabbot failure appears false. Or at least, the referenced line was purposely changed to NOT include quotes 6 months ago: daf1c66#diff-7dae227729788bbef8c05ebb6f0f1345R210 |
yceruto
approved these changes
Sep 13, 2020
OskarStark
approved these changes
Sep 13, 2020
|
Friendly ping |
|
Thank you @weaverryan. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New error:
I used the missing
classjust as an example. I hit this while building a new feature in Symfony. It occurred to me that if, for example, you activate some feature in config and that feature has a required sub-key, why not print theinfo()for that sub key to make it discoverable?