Skip to content

Make RetryTillSaveStore implements the SharedLockStoreInterface #38193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2020
Merged

Make RetryTillSaveStore implements the SharedLockStoreInterface #38193

merged 1 commit into from
Sep 16, 2020

Conversation

jderusse
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets /
License MIT
Doc PR /

The RetryTillSaveStore decorates a non blocking store (ie. RedisStore) to make it blockable.
The issue is: if the decorate store manage SharedLock, the Decorator does not implements this interface. It's currently not possible to get both blocking and sharable store.

@fabpot
Copy link
Member

fabpot commented Sep 16, 2020

Thank you @jderusse.

@fabpot fabpot merged commit 128bbd1 into symfony:master Sep 16, 2020
@fabpot fabpot mentioned this pull request Sep 16, 2020
Closed
@fabpot fabpot mentioned this pull request Oct 5, 2020
Merged
@jderusse jderusse deleted the lock-share-retry branch October 15, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jderusse @fabpot @carsonbot