Skip to content

[FrameworkBundle] loadRoutes shoud receive RoutingPhpFileLoader #38226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2020
Merged

[FrameworkBundle] loadRoutes shoud receive RoutingPhpFileLoader #38226

merged 1 commit into from
Sep 18, 2020

Conversation

grachevko
Copy link
Contributor

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
License MIT

In case when sensio_framework_extra.router.annotations options is set to true or not defined will throw this error

In RoutingConfigurator.php line 28:

Argument 2 passed to Symfony\Component\Routing\Loader\Configurator\RoutingConfigurator::__construct() must be an instance of Symfony\Component\Routing\Loader\PhpFileLoader, instance of Symfony\Component\Routing\Loader\AnnotationFileLoader given, called in /opt/app/vendor/symfony/framework-bundle/Kernel/MicroKernelTrait.php on line 176

@grachevko grachevko changed the title loadRoutes shoud resolve RoutingPhpFileLoader loadRoutes shoud receive RoutingPhpFileLoader Sep 17, 2020
@derrabus
Copy link
Member

You're targeting master, but this bug should be fixed on 5.1. Can you rebase?

@grachevko grachevko changed the base branch from master to 5.1 September 17, 2020 20:39
@grachevko
Copy link
Contributor Author

@derrabus done

@nicolas-grekas nicolas-grekas added this to the 5.1 milestone Sep 18, 2020
@nicolas-grekas nicolas-grekas changed the title loadRoutes shoud receive RoutingPhpFileLoader [FrameworkBundle] loadRoutes shoud receive RoutingPhpFileLoader Sep 18, 2020
@fabpot
Copy link
Member

fabpot commented Sep 18, 2020

Thank you @grachevko.

@fabpot fabpot merged commit 2384f08 into symfony:5.1 Sep 18, 2020
@grachevko grachevko deleted the patch-1 branch September 18, 2020 10:07
@fabpot fabpot mentioned this pull request Sep 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@dunglas dunglas Awaiting requested review from dunglas

@jderusse jderusse Awaiting requested review from jderusse

@lyrixx lyrixx Awaiting requested review from lyrixx

@sroze sroze Awaiting requested review from sroze

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@grachevko @derrabus @fabpot @nicolas-grekas @carsonbot