Add BinaryFileResponse::streamsEntireFile method #38280
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method will return false when the client requests only a specific range of a file. See https://github.com/symfony/psr-http-message-bridge/issues/84
b1fa23e to
fa7435c
Compare
|
to avoid the BC break in 4.4, reflection or a subclass in userland could be used. |
|
@ro0NL Thanks for your response. Note that this is a bug in a Symfony package, not in one of my own. Yes, symfony/psr-http-message-bridge could also use reflection to get the two private properties |
|
I prefer a fix in symfony/psr-http-message-bridge instead. Thank you. |
nicolas-grekas
added a commit
to symfony/psr-http-message-bridge
that referenced
this pull request
Sep 29, 2020
…(iluuu1994) This PR was merged into the 2.0-dev branch. Discussion ---------- Fix BinaryFileResponse with range to psr response conversion Closes #84 As requested by [Fabien](symfony/symfony#38280 (comment)). I think using the slightly less optimal version of checking for a `Content-Range` header is better than relying on reflection. In theory, this could be slightly sub optimal when streaming whole files and setting the `Content-Range` manually but I'm assuming that's very rare in practice. Commits ------- 5d5932d Fix BinaryFileResponse with range to psr response conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method will return false when the client requests only a specific
range of a file.
See https://github.com/symfony/psr-http-message-bridge/issues/84
This method is needed for the
PsrHttpFactoryto knowBinaryFileResponses can pass a stream of the given file to the psr response or if the content needs to be loaded into memory (because only aRangeof the file is streamed). As mentioned in the issue above, I'm not sure if this change is acceptable in a patch because it does have a theoretical BC break asBinaryFileResponseis notfinal.