[Translator] Optional Intl dependency #38283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2020
xabbuh
approved these changes
Sep 23, 2020
|
@ro0NL Looks like there is one test that needs to be adapted. |
|
@xabbuh thanks. remaining failures unrelated 👍 |
chalasr
approved these changes
Sep 24, 2020
fabpot
approved these changes
Sep 24, 2020
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Sep 24, 2020
This PR was merged into the 4.4 branch. Discussion ---------- [Contracts][Translation] Optional Intl dependency | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> same as #38283, and should help streamlining #38230 Commits ------- d65d39d [Contracts][Translation] Optional Intl dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i decided to cast $locale at construct, given its property is documented to be string