[OptionsResolver] Trigger a deprecated option message closure from other options #38293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c5c4227 to
2a69820
Compare
|
Closing as discussed on Slack: this is too much of an edge case and there is already a way to make this work, with some logic in the closure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #37837
The idea is that some other options might need to trigger the execution of a deprecated option message \Closure. See the referenced PR for an example.
When a deprecated option logic involves other values, instead of having to deprecate all those options one by one to account for all the possible scenarios, we would only need to deprecate one and declare its "closure trigger options".