[PhpUnitBridge] Enable a maximum PHPUnit version to be set via SYMFONY_MAX_PHPUNIT_VERSION #38305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Y_MAX_PHPUNIT_VERSION
stof
approved these changes
Sep 25, 2020
fabpot
approved these changes
Sep 26, 2020
|
Thank you @stevegrunwell. |
wouterj
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 3, 2020
…ariable (stevegrunwell) This PR was merged into the master branch. Discussion ---------- Document the SYMFONY_MAX_PHPUNIT_VERSION environment variable This documentation corresponds with symfony/symfony#38305. Commits ------- 517cbc0 Document the SYMFONY_MAX_PHPUNIT_VERSION environment variable
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
SYMFONY_MAX_PHPUNIT_VERSIONenvironment variable, letting users set the maximum version of PHPUnit to be considered when running the PHPUnit Bridge.The use case here comes from testing WordPress using the library; as of the time of this ticket, WordPress' core test suite does not yet support PHPUnit 8.x. As a result, trying to run the WordPress core test suite with PHPUnit Bridge results in the following error under PHP 7.2 or newer:
In this use case, the developer testing against WordPress would set
SYMFONY_MAX_PHPUNIT_VERSION=7.5in their environment (orphpunit.xmlfile) and the PHPUnit Bridge would never go above that version (but would still be free to, for instance, load PHPUnit 6 when running under PHP 7.0).