[Validator] Add Ulid constraint and validator #38322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ->addViolation(); | ||
| } | ||
|
|
||
| if (\strlen($value) !== strspn($value, '0123456789ABCDEFGHJKMNPQRSTVWXYZabcdefghjkmnpqrstvwxyz')) { |
There was a problem hiding this comment.
I think it makes more sense to keep \strlen($value) otherwise a too short ULID but with only valid characters will have violations about being too short AND having invalid characters.
The violation about invalid characters would not be true in this case.
Let me know what you think about it
|
Everything modified except one part which I think makes more sense how it is right now (cf comment in code review) |
fabpot
approved these changes
Sep 29, 2020
6493bc9 to
e36fd55
Compare
|
Thank you @laurent35240. |
Merged
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 6, 2020
…ent35240) This PR was merged into the 5.x branch. Discussion ---------- [Validator] Add documentation for ULID validator Resolves #14298 Related to feature PR symfony/symfony#38322 Commits ------- b37ca01 [Validator] Add documention for ULID validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ULID constraint and validator as mentioned in ticket #38103
I checked for it ulid specifications https://github.com/ulid/spec