[Contracts] move Translatable to symfony/translation-contracts #38328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b627dc to
c633dee
Compare
ro0NL
approved these changes
Sep 28, 2020
c633dee to
efdedfc
Compare
|
/cc @natewiebe13 FYI |
efdedfc to
4e9404d
Compare
|
FYI, I just moved the |
4e9404d to
56f470a
Compare
stof
reviewed
Sep 28, 2020
56f470a to
313a702
Compare
ro0NL
reviewed
Sep 28, 2020
313a702 to
e0e5751
Compare
stof
approved these changes
Sep 28, 2020
fabpot
added a commit
that referenced
this pull request
Sep 28, 2020
This PR was merged into the 5.2-dev branch. Discussion ---------- [lock] Fix non-blocking store fallback | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | / | License | MIT | Doc PR | / Fix issue introduced in #38328 Tests added to avoid regressions. Commits ------- 7a80e41 Fix non-blocking store fallback
|
See alternative proposal in #38330. |
|
@nicolas-grekas maybe a separate PR could be created (and merged) with all the common changes (nullable domain, namespaced On a side note, merging any of these PRs will require updating the blog post as it changes the API. |
|
Closing in favor of #38330 since that's where the consensus seems to go. |
fabpot
added a commit
that referenced
this pull request
Sep 29, 2020
This PR was merged into the 5.2-dev branch. Discussion ---------- [Contracts] add TranslatableInterface | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | #38319 | License | MIT | Doc PR | - An alternative to #38328: - `TranslatableInterface` is added to symfony/contracts; - `Translatable`, still in the component, implements it (and is not final as it makes no sense for a value-object) - the `t()` function is kept in the component - it doesn't fit in the contracts IMHO; - `Translatable::trans()` is not static anymore; - the domain is nullable instead of defaulting to "messages"; - the `t()` function moved in the `Symfony\Component\Translation` namespace (for reference, the `s()` function from String is also namespaced.); - the Twig extension is made strictly polymorphic: if you pass a Translatable, you cannot pass arguments/domain/count. Commits ------- 9224f7a [Contracts] add TranslatableInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the RFC:
Translatableis moved to symfony/contracts;Translatableis not final anymore, it makes no sense for a value-object, especially in contracts;t()function is kept in the component - it doesn't fit in the contracts IMHO;Translatable::trans()is not static anymore;t()function moved in theSymfony\Component\Translationnamespace (for reference, thes()function from String is also namespaced.)