Can define ChatMessage transport to null #38361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Oct 1, 2020
fabpot
approved these changes
Oct 2, 2020
30a58db to
09c9bde
Compare
|
Thank you @odolbeau. |
Merged
fabpot
added a commit
that referenced
this pull request
Jan 14, 2021
This PR was merged into the 5.1 branch. Discussion ---------- Make EmailMessage & SmsMessage transport nullable | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT Ideally, this should have been done in #38361 as it's exactly the same problem: the `transport` method can be called with `null` with deserializing a message from json (for example). Commits ------- d98aca0 Make EmailMessage & SmsMessage transport nullable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using notiier & messenger together to send notification asynchronously.
In order to have json messages in my broker, here is the messenger config I use:
I send a new
ChatMessage:Message is correctly sent to my broker, in json:
{ "subject": "Using notifier & messenger together is amazing!", "recipientId": null, "options": null, "transport": null, "notification": null }But when I want to consume it, as the
transportmethod used by the serializer to create theChatMessagedoesn't acceptnullvalue, I get the following error:This PR correct the problem, even if I'm not sure it's the best way to go...