Skip to content

Changed MIME type mapping to return "jpg" instead of "jpeg" #38364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Changed MIME type mapping to return "jpg" instead of "jpeg" #38364

wants to merge 1 commit into from

Conversation

eltomato89
Copy link

@eltomato89 eltomato89 commented Sep 30, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #38268
License MIT
Doc PR

Fixed order of jpeg mime types for guessExtension() to return "jpg" over "jpeg" as discussed in #38268

@jorrit
Copy link
Contributor

jorrit commented Sep 30, 2020

This file is generated by script Mime/Resources/bin/update_mime_types.php. I think the script needs to be changed as well.

You also need to change UploadedFileTest because it expects jpeg.

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Oct 1, 2020
@nicolas-grekas
Copy link
Member

Additionally to what @jorrit (thanks for the review btw), this should target 4.4.

@fabpot
Copy link
Member

fabpot commented Oct 4, 2020

Taking over in #38407

@fabpot fabpot closed this Oct 4, 2020
fabpot added a commit that referenced this pull request Oct 4, 2020
This PR was merged into the 5.2-dev branch.

Discussion
----------

[Mime] Prefer .jpg instead of .jpeg

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #38364 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        |

Commits
-------

89adb21 [Mime] Prefer .jpg instead of .jpeg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

symfony/mime: prefer jpg extension over jpeg
5 participants