[HttpFoundation] Expired cookies string representation consistency & tests #38369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add consistent behavior when converting expired cookies back and forth from string representation into
Symfony\Component\HttpFoundation\Cookie
instances inCookie::fromString
:Max-Age
is zero andexpires
is in the past, theexpires
date is kept as is (previous behavior:expires
is overwritten with current timestamp because it is reset to current timestamp +Max-Age
)Max-Age
is zero andexpires
is in the future, expires is reset to current timestamp, asMax-Age
is the preferred "source of truth" (same as previous behavior)Max-Age
in a cookie string and howexpires
andMax-Age
interactexpiresTimestamp
so converting to a unix timestamp can be reused inCookie::fromString
This is more a new feature than a bug fix in my mind, therefore I would include it in 5.1+.