Skip to content

[ErrorHandler][DebugClassLoader] Do not check Mockery mocks classes #38373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fancyweb
Copy link
Contributor

@fancyweb fancyweb commented Oct 1, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #37916
License MIT
Doc PR -

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(there are a few instanceof ProphecySubjectInterface in the code that could also check instanceof MockInterface and remove some false-positive deprecations btw.)

@fabpot
Copy link
Member

fabpot commented Oct 2, 2020

Thank you @fancyweb.

@fabpot fabpot merged commit 9a5a856 into symfony:4.4 Oct 2, 2020
@fancyweb fancyweb deleted the error-handler-debug-class-loader-ignore-mockery-mock branch October 2, 2020 07:32
This was referenced Oct 4, 2020
derrabus added a commit that referenced this pull request Jun 22, 2021
… classes (adoy)

This PR was merged into the 4.4 branch.

Discussion
----------

[ErrorHandler] [DebugClassLoader] Do not check Phake mocks classes

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | [Phake Issue #300](phake/phake#300)
| License       | MIT
| Doc PR        | -

Similar issue as #38373 but with Phake mocking framework

Commits
-------

9ed93df [ErrorHandler][DebugClassLoader] Do not check Phake mocks classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants