Skip to content

[Console] Remove "php" invokation from help messages. #38397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2020

Conversation

rodrigoaguilera
Copy link

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
License MIT

Discusstion started here:
#38349

I was a bit puzzled to find that the help for the list and help commands suggests that you call the console application by prefixing it with php myconsoleapp.

As suggested in the PR above I am removing the php prefix from the help.

I am providing a script with a shebang like the first example suggested in the following link:
https://symfony.com/doc/current/components/console.html
Eventually I want to distribute my console app as docker image so there is no need for php installed or the users even knowing is written in php.
The script name is easy to override by just setting a different value to $_SERVER['PHP_SELF'] but this php prefix is hardcoded into the help strings for the the two default commands available.

Slightly related to #38347 as I am trying to improve the console help output.

@fabpot
Copy link
Member

fabpot commented Oct 4, 2020

Thank you @rodrigoaguilera.

@fabpot fabpot merged commit 42d86cf into symfony:master Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants