Skip to content

[DoctrineBridge] fix and replace namespace to Uid #38419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2020
Merged

[DoctrineBridge] fix and replace namespace to Uid #38419

merged 1 commit into from
Oct 6, 2020

Conversation

maxhelias
Copy link
Contributor

Q A
Branch? master
Bug fix? yes
New feature? no
Deprecations? no
Tickets #37678 (comment)
License MIT
Doc PR ...

This post should also be corrected: https://symfony.com/blog/new-in-symfony-5-2-doctrine-types-for-uuid-and-ulid cc @javiereguiluz

@nicolas-grekas nicolas-grekas added this to the 5.2 milestone Oct 5, 2020
nicolas-grekas
nicolas-grekas reviewed Oct 5, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add some basic tests please?

src/Symfony/Bridge/Doctrine/Uid/UlidGenerator.php Outdated
@@ -9,7 +9,7 @@
* file that was distributed with this source code.
*/

namespace Symfony\Bridge\Doctrine\Types;
namespace Symfony\Bridge\Doctrine\Uid;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IdGenerator would be a better fit actually

@nicolas-grekas
Copy link
Member

This post should also be corrected: symfony.com/blog/new-in-symfony-5-2-doctrine-types-for-uuid-and-ulid cc @javiereguiluz

now fixed, it's using IdGenerator, in anticipation for this PR.

@maxhelias maxhelias force-pushed the fix-namespace-uidgenerator branch 2 times, most recently from c0fb59c to e3b0d56 Compare October 5, 2020 17:37
nicolas-grekas
nicolas-grekas reviewed Oct 5, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here are some nitpicking
don't forget to update your commit message (and PR title)

@maxhelias maxhelias force-pushed the fix-namespace-uidgenerator branch from e3b0d56 to a816fd4 Compare October 5, 2020 17:42
@maxhelias
Copy link
Contributor Author

I'll watch the fail travis quickly

@maxhelias maxhelias force-pushed the fix-namespace-uidgenerator branch from a816fd4 to 28d1169 Compare October 5, 2020 21:45
@maxhelias
Copy link
Contributor Author

It's now okay, the remaining errors are unrelated

@fabpot
Copy link
Member

fabpot commented Oct 6, 2020

Thank you @maxhelias.

@fabpot fabpot merged commit c4141f5 into symfony:master Oct 6, 2020
@maxhelias maxhelias deleted the fix-namespace-uidgenerator branch October 6, 2020 10:57
@fabpot fabpot mentioned this pull request Oct 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug DoctrineBridge Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@maxhelias @nicolas-grekas @fabpot @carsonbot