Skip to content

[String][AsciiSlugger] Fix typo #38443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2020
Merged

[String][AsciiSlugger] Fix typo #38443

merged 1 commit into from
Oct 6, 2020

Conversation

ErnadoO
Copy link
Contributor

@ErnadoO ErnadoO commented Oct 6, 2020

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

I guess there was a little mistake on PR #38198 : In exception message it should be $symbolsMap instead of $symbolMap

;)

@nicolas-grekas nicolas-grekas modified the milestones: 5.1, 5.2 Oct 6, 2020
@nicolas-grekas nicolas-grekas changed the base branch from master to 5.x October 6, 2020 17:37
@nicolas-grekas
Copy link
Member

Good catch, thanks @ErnadoO.

@nicolas-grekas nicolas-grekas merged commit ca220a1 into symfony:5.x Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review String
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ErnadoO @nicolas-grekas @carsonbot