[Messenger] Add DelayStamp::delayFor() and DelayStamp::delayUntil() #38484
+21
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
approved these changes
Oct 8, 2020
fabpot
approved these changes
Oct 8, 2020
ce32b28 to
c5de1eb
Compare
|
Thank you @Nyholm. |
|
Thank you for the reviews and merge. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will revert the work by @Toflar in #38141. He added some helper methods and I want to add a generic factory method that adds a DateInterval.
This PR will also close #38480 and fix #38459. It is also related to a comment in #36512 (comment) that was liked by a few people.
Maybe adding both
DelayStamp::delayFor(\DateInterval)andDelayStamp::delayUntil(\DateTimeInterface)is overkill. But this covers all the bases and I hope that it will be the last change to this small class.