Skip to content

[Messenger] support for multiple bindings on the same queue #38485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: 7.4
Choose a base branch
from
+242 −123
Open

[Messenger] support for multiple bindings on the same queue #38485

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
74339e7
37233 - Support multiple bindings for a queue
inferont Oct 8, 2020
b5e2f0e
Tweak to exception message when invalid options for bindings are prov…
inferont Oct 9, 2020
2bf09a7
Merge remote-tracking branch 'origin/master' into 37233-support-multi…
Jan 6, 2023
4b4dd05
Update the branch to target symfony 6.3
Jan 6, 2023
b204b07
Fix the failing test, remove unused variables, add missing type decla…
Jan 8, 2023
5b6f842
Merge branch 'symfony:6.3' into 37233-support-multiple-bindings
githoober Jan 8, 2023
4c1e3da
Remove unused variables
Jan 8, 2023
768b1ca
Improve handling of new and deprecated options, add more test coverage
Jan 12, 2023
2275b22
Temporarily remove deprecation logic
Jan 13, 2023
35d6478
Restore deprecation triggering
Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'origin/master' into 37233-support-multi… 
…ple-bindings

# Conflicts:
#	src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php
  • Loading branch information
Oleg Namaka committed Jan 6, 2023
commit 2bf09a7ab5a4a35b79352e8fd3c8cc5799d9cad8
2 changes: 1 addition & 1 deletion src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ private static function validateOptions(array $options): void
}

if (0 < \count($invalidQueueOptions = array_diff(array_keys($queue), self::AVAILABLE_QUEUE_OPTIONS, self::ORIGINAL_BINDING_KEYS))) {
trigger_deprecation('symfony/messenger', '5.1', 'Invalid queue option(s) "%s" passed to the AMQP Messenger transport. Passing invalid queue options is deprecated.', implode('", "', $invalidQueueOptions));
throw new LogicException(sprintf('Invalid queue option(s) "%s" passed to the AMQP Messenger transport.', implode('", "', $invalidQueueOptions)));
} elseif (0 < \count($invalidQueueOptions = array_diff(array_keys($queue), self::AVAILABLE_QUEUE_OPTIONS))) {
trigger_deprecation('symfony/messenger', '5.2', 'Deprecated queue option(s) "%s" passed to the AMQP Messenger transport. The "bindings" option should be used rather than "binding_keys" and "binding_arguments".', implode('", "', $invalidQueueOptions));
}
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.