Skip to content

[HttpFoundation] Fix Range Requests #38516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2020
Merged

[HttpFoundation] Fix Range Requests #38516

merged 1 commit into from
Oct 14, 2020

Conversation

BattleRattle
Copy link
Contributor

@BattleRattle BattleRattle commented Oct 11, 2020 •
edited
Loading

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #38295
License MIT
Doc PR

This PR fixes some deviations from RFC 7233 for handling range requests, mentioned in #38295.

  • overlapping ranges are now satisfiable (e.g. when requested range end is larger than the file size)
  • range units other than bytes will get ignored
  • range requests for methods other than GET will be ignored

I did not manage yet to implement the support for multiple ranges, but also don't know, if that's needed here.

@BattleRattle BattleRattle changed the title Bugfix/range queries [HttpFoundation] Fix Range Requests Oct 11, 2020
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Oct 12, 2020
nicolas-grekas
nicolas-grekas reviewed Oct 12, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this apply to branch 3.4 also? If yes, this should be rebased+target 3.4.

I did not manage yet to implement the support for multiple ranges, but also don't know, if that's needed here.

It's not needed IMHO.

@BattleRattle BattleRattle requested a review from dunglas as a code owner October 12, 2020 20:32
@BattleRattle BattleRattle changed the base branch from 5.1 to 3.4 October 12, 2020 20:32
@BattleRattle
Copy link
Contributor Author

Doesn't this apply to branch 3.4 also? If yes, this should be rebased+target 3.4.

You're right, I changed it to 3.4. Thanks for the hint

@fabpot
Copy link
Member

fabpot commented Oct 14, 2020

Thank you @BattleRattle.

@fabpot fabpot merged commit 89dddd1 into symfony:3.4 Oct 14, 2020
This was referenced Oct 28, 2020
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@dunglas dunglas Awaiting requested review from dunglas

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@BattleRattle @fabpot @nicolas-grekas @carsonbot