[HttpClient] simplify retry mechanism around RetryStrategyInterface #38532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
reviewed
Oct 12, 2020
src/Symfony/Component/HttpClient/Retry/GenericRetryStrategy.php
Outdated
Show resolved
Hide resolved
5c31b3e to
4148f78
Compare
4148f78 to
544c3e8
Compare
jderusse
approved these changes
Oct 13, 2020
stof
reviewed
Oct 13, 2020
| use Symfony\Contracts\HttpClient\Exception\TransportExceptionInterface; | ||
|
|
||
| /** | ||
| * Decides to retry the request when HTTP status codes belong to the given list of codes. |
There was a problem hiding this comment.
This should document that its delay implementation is an exponential backoff. That got lost when naming it generic.
Merged
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 21, 2020
This PR was merged into the 5.x branch. Discussion ---------- Fix documentation about RetryStrategy Change introduced in symfony/symfony#38532 Commits ------- 19521c3 Fix documentation about RetryStrategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #38466
I feel like the mechanism behind RetryableHttpClient is too bloated for no pragmatic reasons.
I propose to merge RetryDeciderInterface and RetryBackoffInterface into one single RetryStrategyInterface.
Having two separate interfaces supports no real-world use case. The only implementations we provide are trivial, and they can be reused by extending the provided GenericRetryStrategy implementation if one really doesn't want to duplicate that.
The methods are also simplified by accepting an AsyncContext as argument. This makes the signatures shorter and allows accessing the "info" of the request (allowing to decide based on the IP of the host, etc).
/cc @jderusse