Skip to content

[String] fix "is too large" ValueError on PHP 8 #38546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2020
Merged

[String] fix "is too large" ValueError on PHP 8 #38546

merged 1 commit into from
Oct 13, 2020

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 5.1 milestone Oct 13, 2020
@stof
Copy link
Member

stof commented Oct 13, 2020

What is this number here ?

@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Oct 13, 2020 •
edited
Loading

It's INT32_MAX, as hardcoded in php-src.

@stof
Copy link
Member

stof commented Oct 13, 2020

Do they expose such a constant, when their APIs use that as max ?

@nicolas-grekas
Copy link
Member Author

Nope, it's an internal macro...

@nicolas-grekas nicolas-grekas merged commit e95f87d into symfony:5.1 Oct 13, 2020
@nicolas-grekas nicolas-grekas deleted the str-fix branch October 13, 2020 12:40
@fabpot fabpot mentioned this pull request Oct 14, 2020
Merged
@fabpot fabpot mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review String
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @stof @carsonbot