Fix clearing cache when build_dir equals cache_dir #38549
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
requested changes
Oct 13, 2020
| if ($useBuildDir) { | ||
| $fs->rename($realBuildDir, $oldBuildDir); | ||
| // Copy the content of the warmed cache in the build dir | ||
| $fs->copy($realCacheDir, $realBuildDir); |
There was a problem hiding this comment.
One need to use mirror().
Also, You just removed $realCacheDir, you cannot use it here.
There was a problem hiding this comment.
$warmupDir was renamed to $realCacheDir previously
Nyholm
added a commit
to Nyholm/symfony
that referenced
this pull request
Oct 13, 2020
|
Fixed in #38548 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible solution for equal
build_dirandcache_dirintroduced in #36515/cc @mnapoli