[Lock] Reset Key lifetime time before we acquire it #38553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
approved these changes
Oct 13, 2020
fabpot
approved these changes
Oct 14, 2020
|
Which branch should we target? 4.4? |
|
This should target 4.4. |
|
@Nyholm Can you rebase? |
86f6f53 to
f87c11e
Compare
ab6fc4d to
54b7e98
Compare
e9fc16c to
55ad702
Compare
|
Yes, rebased and squashed. |
fabpot
added a commit
that referenced
this pull request
Oct 14, 2020
This PR was merged into the 5.x branch. Discussion ---------- [Lock] Reset lifetime on acquireRead() | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | n/a Same as #38553 but this is for `acquireRead()` instead of `acquire()`. `acquireRead()` is new in 5.2. Commits ------- de412bf Reset lifetime on acquireRead()
fabpot
approved these changes
Oct 14, 2020
|
Thank you @Nyholm. |
Merged
Nyholm
added a commit
that referenced
this pull request
Oct 15, 2020
…jderusse) This PR was merged into the 5.x branch. Discussion ---------- [Semaphore] Reset Key lifetime time before we acquire it | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | / | License | MIT | Doc PR | / This is the same issue fixed by #38553 but for Semaphore component. Commits ------- e7ffd5d Reset Key lifetime time in semaphore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im out on somewhat deep water now. I am pretty sure we should reset the Key lifetime every time we acquire it. Without it it will me tricky to re-use a lock. (As pointed out by #38541)
@jderusse can you confirm.