[Console] Don't register signal handlers if pcntl is disabled #38589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7231ead to
2970f34
Compare
jderusse
reviewed
Oct 15, 2020
derrabus
reviewed
Oct 15, 2020
src/Symfony/Component/Console/SignalRegistry/SignalRegistry.php
Outdated
Show resolved
Hide resolved
1fe2517 to
1c0e10c
Compare
jderusse
approved these changes
Oct 15, 2020
1c0e10c to
8fe8763
Compare
fabpot
approved these changes
Oct 16, 2020
|
Thank you @chalasr. |
lyrixx
reviewed
Oct 16, 2020
| $this->signalRegistry = new SignalRegistry(); | ||
| if (\defined('SIGINT')) { | ||
| if (\defined('SIGINT') && SignalRegistry::isSupported()) { | ||
| $this->signalRegistry = new SignalRegistry(); |
There was a problem hiding this comment.
Sorry for the late review, but the PR has changed before my review.
So here we go:
This change is wrong. See getSignalRegistry() method:
https://github.com/chalasr/symfony/blob/8fe876341e860ea3fa13bec3c2bdf77a66ead424/src/Symfony/Component/Console/Application.php#L111-L114
Then, a lot of fatal error could occurs since the registry might not be defined
There was a problem hiding this comment.
Oops, thank you; #38602 makes it nullable
lyrixx
added a commit
that referenced
this pull request
Oct 16, 2020
This PR was merged into the 5.x branch. Discussion ---------- [Console] Fix signal management | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Missed in #38589 Commits ------- 36e41b8 [Console] Fix Application::getSignalRegistry() retval
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR skips the default signal registration when pcntl is not installed or disabled via the
disable_functionsINI directive (which is common for prod infrastructures).When registering a
SignalableCommand, a clear exception is thrown.Best reviewed without whitespaces