[Cache] Fixed broken test #38709
Merged
[Cache] Fixed broken test #38709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Oct 25, 2020
fabpot
approved these changes
Oct 25, 2020
|
Thank you @Nyholm. |
derrabus
added a commit
that referenced
this pull request
Oct 25, 2020
This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Cache] Fixed tests.. again | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? |no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Hm.. Im sorry for the many PRs. I failed to fix this in #38709. Commits ------- ac0e25e [Cache] Fixed tests.. again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this line of code in #38635
However, some time between 4.4 and 5.x the
FilesystemAdapterTest::rmdir()was removed. This PR make sure tests does not fail on 5.x.I target 4.4, I believe it will be simple to merge up to 5.1 and 5.x. Let me know if I should target 5.x instead.