Skip to content

[Cache] Fixed tests.. again #38785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2020
Merged

[Cache] Fixed tests.. again #38785

merged 1 commit into from
Oct 25, 2020

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Oct 25, 2020

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Hm.. Im sorry for the many PRs.

I failed to fix this in #38709.

@derrabus
Copy link
Member

Shall we also add symfony/filesystem to require-dev of symfony/cache? 🤔

@Nyholm
Copy link
Member Author

Nyholm commented Oct 25, 2020

symfony/cache has a dev dependency on symfony/config. So symfony/filesystem is already added. But sure. It is better to be explicit

@derrabus
Copy link
Member

Thank you Tobias.

@derrabus derrabus merged commit c29f7b4 into symfony:4.4 Oct 25, 2020
@Nyholm Nyholm deleted the cache-tests2 branch October 25, 2020 18:44
@Nyholm
Copy link
Member Author

Nyholm commented Oct 25, 2020

Thank you for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Cache Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nyholm @derrabus @carsonbot