Skip to content

[Notifier] Add unit tests for NullMessage, NullTransport and NullTransportFactory #38842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2020
Merged

[Notifier] Add unit tests for NullMessage, NullTransport and NullTransportFactory #38842

merged 1 commit into from
Nov 2, 2020

Conversation

jschaedl
Copy link
Contributor

Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

@jschaedl jschaedl force-pushed the notifier-tests-null-transport branch 2 times, most recently from 329f63b to 528b6ee Compare October 27, 2020 14:09
@nicolas-grekas nicolas-grekas added this to the 5.2 milestone Oct 27, 2020
@jderusse
Copy link
Member

Shouldn't this PR targets the branch where classes were introduced?

@jschaedl
Copy link
Contributor Author

@jderusse I don't know. My last PR's including unit tests for the Notifier was targeting master (https://github.com/symfony/symfony/pull/38315/files) so I thought targeting 5.x is fine here.
But if there is any rule I'm happy to target another branch.

@derrabus
Copy link
Member

5.x is correct.

@jderusse jderusse force-pushed the notifier-tests-null-transport branch from 16b8ff2 to 8a78dc2 Compare November 2, 2020 23:55
@jderusse
Copy link
Member

jderusse commented Nov 2, 2020

Thank you @jschaedl.

@jderusse jderusse merged commit 0dfbeb4 into symfony:5.x Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@jderusse jderusse jderusse approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Notifier Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
5 participants
@jschaedl @jderusse @derrabus @nicolas-grekas @carsonbot