Skip to content

Missing translations for Chinese (zh_CN) #38732 #38847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
Oct 28, 2020
Merged

Missing translations for Chinese (zh_CN) #38732 #38847

merged 0 commits into from
Oct 28, 2020

Conversation

fd6130
Copy link
Contributor

@fd6130 fd6130 commented Oct 27, 2020 •
edited
Loading

Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #38732
License MIT

Added missing translations for zh_CN in Form, Security, Validator.

@fd6130 fd6130 requested a review from xabbuh as a code owner October 27, 2020 18:05
@carsonbot carsonbot added this to the 3.4 milestone Oct 27, 2020
Nyholm
Nyholm reviewed Oct 27, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. It looks good.

I used Google Translate to confirm this. I might be very wrong in be comments below, but can you double check?

Nyholm
Nyholm approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool cool.

Thank you

@fabpot
Copy link
Member

fabpot commented Oct 28, 2020

Thank you @fd6130.

@fabpot fabpot closed this Oct 28, 2020
@fabpot fabpot force-pushed the zh_CN_translation branch from facc4ff to 952df24 Compare October 28, 2020 05:23
@fabpot fabpot merged commit 48cbe31 into symfony:3.4 Oct 28, 2020
@fd6130 fd6130 deleted the zh_CN_translation branch October 16, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@Nyholm Nyholm Nyholm approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fd6130 @fabpot @Nyholm @carsonbot