Skip to content

[FrameworkBundle] Fixing TranslationUpdateCommand failure when using "--no-backup" #38867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2020
Merged

[FrameworkBundle] Fixing TranslationUpdateCommand failure when using "--no-backup" #38867

merged 1 commit into from
Oct 28, 2020

Conversation

liarco
Copy link
Contributor

@liarco liarco commented Oct 28, 2020 •
edited
Loading

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

5.0.0 removed TranslationWriter::disableBackup() but TranslationUpdateCommand still has --no-backup flag. Using that flag throws an error so I think that removing it without deprecation may be the right choice.

Thrown error:

In TranslationUpdateCommand.php line 287:
                                                                            
  Attempted to call an undefined method named "disableBackup" of class "Symfony\Component\Translation\Writer\TranslationWriter".

Further references to the topic:

@carsonbot carsonbot added this to the 5.1 milestone Oct 28, 2020
@fabpot
Copy link
Member

fabpot commented Oct 28, 2020

Thank you @liarco.

@fabpot fabpot merged commit 8c20b90 into symfony:5.1 Oct 28, 2020
@fabpot fabpot mentioned this pull request Nov 10, 2020
Merged
@fabpot fabpot mentioned this pull request Nov 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@liarco @fabpot @carsonbot