Skip to content

[SecurityBundle] inject only compatible token storage implementations for usage tracking #38869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2020
Merged

[SecurityBundle] inject only compatible token storage implementations for usage tracking #38869

merged 1 commit into from
Oct 31, 2020

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Oct 28, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #36720
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.4 milestone Oct 28, 2020
@xabbuh xabbuh mentioned this pull request Oct 28, 2020
Closed
wouterj
wouterj approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Should we maybe add a test for this?

derrabus
derrabus approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we cover this with a test. 😃

@xabbuh
Copy link
Member Author

xabbuh commented Oct 29, 2020

I am going to add a test later today. :)

@xabbuh
Copy link
Member Author

xabbuh commented Oct 31, 2020

test added

@wouterj
Copy link
Member

wouterj commented Oct 31, 2020

Thank you Christian.

@wouterj wouterj merged commit d71c404 into symfony:4.4 Oct 31, 2020
@xabbuh xabbuh deleted the issue-36720 branch October 31, 2020 12:57
@fabpot fabpot mentioned this pull request Nov 10, 2020
Merged
This was referenced Nov 29, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@derrabus derrabus derrabus approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Bug SecurityBundle Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @wouterj @derrabus @carsonbot