Skip to content

remove reflection-docblock from mime requirements #38888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2020
Merged

remove reflection-docblock from mime requirements #38888

merged 1 commit into from
Oct 30, 2020

Conversation

garak
Copy link
Contributor

@garak garak commented Oct 30, 2020

Q A
Branch? 5.x
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #38886
License MIT
Doc PR not needed

See related issue

derrabus
derrabus requested changes Oct 30, 2020
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency is used by the tests introduced with #37847. We need to keep it, but require-dev is probably the better place for it.

@derrabus derrabus added this to the 5.2 milestone Oct 30, 2020
@derrabus
Copy link
Member

While we're at it: symfony/property-access, symfony/property-info and symfony/serializer should also not be mandatory dependencies of the Mime component.

@derrabus derrabus added the Mime label Oct 30, 2020
@derrabus
Copy link
Member

Sorry, I should have been more precise here. The three packages I mentioned need to be dev dependencies as well. Sorry for the confusion.

@fabpot fabpot force-pushed the remove-mime-requirement branch from 7d9f25b to f33d16f Compare October 30, 2020 14:55
@fabpot
Copy link
Member

fabpot commented Oct 30, 2020

Thank you @garak.

@fabpot fabpot merged commit 5701b8b into symfony:5.x Oct 30, 2020
@fabpot fabpot mentioned this pull request Nov 10, 2020
Merged
@garak garak deleted the remove-mime-requirement branch December 15, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug Mime Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

symfony/mime requires phpdocumentor/reflection-docblock but doesn't use it
4 participants
@garak @derrabus @fabpot @carsonbot