Skip to content

[PhpUnitBridge] Fix wrong check for exporter in ConstraintTrait #38895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2020
Merged

[PhpUnitBridge] Fix wrong check for exporter in ConstraintTrait #38895

merged 1 commit into from
Oct 30, 2020

Conversation

alcaeus
Copy link
Contributor

@alcaeus alcaeus commented Oct 30, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
License MIT

I'll just go hide in the corner after messing up this check. 🤦‍♂️

@carsonbot carsonbot added this to the 4.4 milestone Oct 30, 2020
@alcaeus alcaeus changed the title Fix wrong check for exporter in ConstraintTrait [PhpUnitBridge] Fix wrong check for exporter in ConstraintTrait Oct 30, 2020
@derrabus
Copy link
Member

Good catch, thanks Andreas.

@derrabus derrabus merged commit 9eeac8d into symfony:4.4 Oct 30, 2020
@alcaeus alcaeus deleted the fix-wrong-exporter-check branch October 30, 2020 14:10
@fabpot fabpot mentioned this pull request Nov 10, 2020
Merged
This was referenced Nov 29, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug PhpUnitBridge Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@alcaeus @derrabus @nicolas-grekas @carsonbot