[FrameworkBundle] Add "Usages" to debug:container output #38903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, what a great first contribution =) |
derrabus
requested changes
Oct 30, 2020
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/Descriptor.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/Descriptor.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/Descriptor.php
Outdated
Show resolved
Hide resolved
|
Fixed @derrabus's comments in my own commits. Please check again! |
jderusse
reviewed
Oct 30, 2020
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/Descriptor.php
Outdated
Show resolved
Hide resolved
jderusse
reviewed
Oct 30, 2020
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/Descriptor.php
Outdated
Show resolved
Hide resolved
jderusse
reviewed
Oct 30, 2020
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/Descriptor.php
Outdated
Show resolved
Hide resolved
derrabus
requested changes
Oct 30, 2020
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/builder_1_arguments.md
Outdated
Show resolved
Hide resolved
|
@bertterheide Now that the 6.1 branch is open, can you retarget it and resolve the conflicts. I would love to be able to merge it for the upcoming 6.1 release. Thank you. |
|
@bertterheide @fabpot Hi, this PR seems stale but could be nice imho, can I try continuing the work on this? |
|
Since this has been inactive for a while, I assume it safe for you to continue to work. |
|
Oh, that is awesome! Thank you <3 |
|
fantastic thx! |
e29f17a to
576a7f6
Compare
94noni
reviewed
Jul 15, 2022
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/JsonDescriptor.php
Outdated
Show resolved
Hide resolved
|
Rebased the code on 6.2, updated the PR! |
chalasr
approved these changes
Jul 15, 2022
fabpot
approved these changes
Jul 16, 2022
|
Thank you @bertterheide. |
27e8183 to
e1ab83b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds "Usages" output to the debug:container command which allows a user to see which services require the requested service.