[Console] Make error message more verbose #38919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
reviewed
Oct 31, 2020
| @@ -165,11 +165,25 @@ private function parseArgument(string $token) | |||
| // unexpected argument | |||
| } else { | |||
| $all = $this->definition->getArguments(); | |||
| $symfonyCommandName = null; | |||
| if (($inputArgument = $all[$key = array_key_first($all)] ?? null) && 'command' === $inputArgument->getName()) { | |||
| $symfonyCommandName = $this->tokens[0] ?? null; | |||
There was a problem hiding this comment.
hmm, what if people use short command name ? like d:m:m instead of doctrine: migration:migrate
Just wondering what should be the output...
There was a problem hiding this comment.
Good question. The output would be:
Too many arguments to "d:m:m" command, expected arguments "version".
chalasr
approved these changes
Oct 31, 2020
stof
reviewed
Oct 31, 2020
| @@ -165,11 +165,25 @@ private function parseArgument(string $token) | |||
| // unexpected argument | |||
| } else { | |||
| $all = $this->definition->getArguments(); | |||
| $symfonyCommandName = null; | |||
| if (($inputArgument = $all[$key = array_key_first($all)] ?? null) && 'command' === $inputArgument->getName()) { | |||
| $symfonyCommandName = $this->tokens[0] ?? null; | |||
There was a problem hiding this comment.
The command name is not always $this->tokens[0]. bin/console -v secrets:list will have -v as $this->tokens[0]
There was a problem hiding this comment.
You should use $this->arguments['command'][0] instead (when we reach this error, we know that the command argument has already been parsed)
There was a problem hiding this comment.
Awesome.
You are correct. I've updated the PR.
❯ bin/console -v secrets:list foobar
In ArgvInput.php line 186:
[Symfony\Component\Console\Exception\RuntimeException]
No arguments expected for "secrets:list" command, got "foobar".
yceruto
approved these changes
Nov 1, 2020
fabpot
approved these changes
Nov 1, 2020
be44cfa to
ef221e8
Compare
|
Thank you @Nyholm. |
|
Thank you for all reviews and for merging. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make the error message a bit more verbose when you are using too many or too few arguments.