[PHPUnitBridge] Fixed crash on Windows with PHP 8 #38921
Conversation
The install command crashed with the message "The filename, directory name, or volume label syntax is incorrect.". It happens only on Windows with PHP 8. Probably due to https://github.com/php/php-src/blob/PHP-8.0/UPGRADING#L1121-L1123
|
Great. Thank you. Your reproducer repo is helpful indeed. Could we do a test here on this repo too? Just to make sure this never breaks again? |
|
Do you have an idea how to test it? AppVeyor runs the tests only with PHP 7.2.5. |
|
Hm. I’m not sure. @derrabus maybe have some input? Maybe start by adding the same github action test as in your test repo? |
|
@Nyholm PHP 8 on Windows does not happen on our CI yet. If someone with a Windows machine could confirm the bug and the solution, I think we can merge this without a test. |
|
Thank you @villfa. |
|
I just tried it on the 4.4 branch. I can both confirm the reported bug and that the fix solves it for me (Windows 10 with PHP 8 Beta 3) 👍 |
The install command crashed with the message "The filename, directory name, or volume label syntax is incorrect.".
It happens only on Windows with PHP 8.
Probably due to https://github.com/php/php-src/blob/PHP-8.0/UPGRADING#L1121-L1123
I have a small repo to show the problem and how it is fixed: https://github.com/villfa/test-phpunit-bridge