-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Process] Dont test TTY if there is no TTY support #38950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Nyholm
commented
Nov 1, 2020
Q | A |
---|---|
Branch? | 4.4 |
Bug fix? | no |
New feature? | no |
Deprecations? | no |
Tickets | Fix #38946 |
License | MIT |
Doc PR |
Well, this would make our tests pass. But my understanding is that the TTY detection that you use to skip the test is part of what we want to test here. Let's say we would break that detection logic. We would never know because the corresponding tests would flip from green to skipped. 😕 |
Is it testing Isn't it testing that the |
PR updated. Thank you |
@Nyholm If I change |
If If What alternative strategy do you have to solve #38946? |
None. 😕 |
Thank you @Nyholm. |