[Intl] deprecate polyfills in favor of symfony/polyfill-intl-icu #38974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3cbbd7 to
04c1b4d
Compare
stof
approved these changes
Nov 3, 2020
12c7b00 to
a8d54bc
Compare
derrabus
approved these changes
Nov 3, 2020
9c80039 to
1421dcf
Compare
350de91 to
2dad6d7
Compare
stof
reviewed
Nov 3, 2020
stof
reviewed
Nov 3, 2020
| @@ -59,6 +59,8 @@ public function testTransChoiceWithExplicitLocale($expected, $id, $number) | |||
| } | |||
|
|
|||
| /** | |||
| * @requires extension intl | |||
There was a problem hiding this comment.
why ? the polyfill should be enough as they work in the en locale.
There was a problem hiding this comment.
that's the contracts, we don't want to add the polyfill to it.
There was a problem hiding this comment.
then maybe change that to a check on the class existence (@requires class NumberFormatter) so that it accepts both the polyfill or the extension ?
There was a problem hiding this comment.
We already have this @requires in the very next test case.
And we don't care to make this testable with the polyfill - that wouldn't provide anything more AFAIK.
2dad6d7 to
6ad0169
Compare
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Apr 9, 2021
This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [Intl] Remove documentation about deprecated code These classes was deprecated in symfony/symfony#38974. They belong to `symfony/polyfill-intl-icu`. This PR will fix #14532 Commits ------- 9a69cac [Intl] Remove documentation about deprecated code
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows symfony/polyfill#310
/cc @stof