[DependencyInjection] autoconfigure behavior describing tags on decorators #38999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Nov 5, 2020
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
|
For reference, disabling autoconfig for decorating services has been proposed by @stof in #30391 (comment) The drawback was also described:
As pointed out, all tags that describe behavior that belongs to the service itself should be preserved. Now, I don't know how to make this generic... |
6bd1db1 to
a12aca6
Compare
|
I have reworked the patch to account for some more tags. |
a12aca6 to
73a3b83
Compare
nicolas-grekas
approved these changes
Nov 13, 2020
Merged
fabpot
added a commit
that referenced
this pull request
Feb 4, 2022
…ecorators (LANGERGabrielle) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Fix AsEventListener not working on decorators | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | When using the `AsEventListener` on a decorator, it is ignored instead of registering the decorator as an event listener. This is because autoconfigured tags are not applied to decorators since #30417. `EventSubscriberInterface` works as expected since #38999, when the `kernel.event_subscriber'` tag was added to a list of "behavior describing tags" which can be autoconfigured onto decorators. This PR adds `kernel.event_listener` to this default list of tags, making `AsEventListener` work as expected on decorators. Commits ------- 5fbb217 Added `kernel.event_listener` to the default list of behavior describing tags, fixing AsEventListener attribute not working on decorators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.