[Yaml] Fix parsing multidimensional inline collections #39013
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9ec712 to
77fc10e
Compare
|
I just realized this could break when "[" or "]" are appearing in strings. On the other hand this issue isn't new the following yaml isn't parsable in the master as well: While searching through the issues if this is known I found this old pull request #33763 which includes the exact same fix 😄 . The problem I have here is mentioned as well and not fixed yet. @xabbuh are you planning to fix the issues in your PR? Shall I close here? |
|
I hope to be able to work on my PR on Friday. I will keep you updated if I make any progress there. |
|
Thank you for working on this @simonberger. I have added your test case to #33763. |
fabpot
added a commit
that referenced
this pull request
Nov 19, 2020
This PR was merged into the 4.4 branch. Discussion ---------- [Yaml] fix lexing nested sequences/mappings | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #34805, #37788, #37876, #39011, #39013, #39064 | License | MIT | Doc PR | Commits ------- 4c15f80 fix lexing nested sequences/mappings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multidimensional yaml inline collections spread over multiple lines could not be parsed.
I could not find new problems fixing it that way. Also the thrown exceptions for incomplete collections are the same.